fix(nimbus): capture branch feature value changes in history changelog#14999
Merged
jaredlockhart merged 1 commit intomainfrom Mar 23, 2026
Merged
fix(nimbus): capture branch feature value changes in history changelog#14999jaredlockhart merged 1 commit intomainfrom
jaredlockhart merged 1 commit intomainfrom
Conversation
jaredlockhart
requested review from
freshstrangemusic,
mikewilli,
relud and
yashikakhurana
as code owners
yashikakhurana
approved these changes
Mar 20, 2026
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Nicely done, thank you @jaredlockhart great find
jaredlockhart
force-pushed
the
2026-03-20-history-feature-values
branch
2 times, most recently
from
de378fb to
db087fc
Compare
Because * NimbusBranchesForm.save() called super().save() which triggered NimbusChangeLogFormMixin.save() to generate the changelog snapshot before self.branches.save() ran, causing the changelog to capture stale feature values instead of the updated ones * Feature value changes were invisible on the History page This commit * Moves self.branches.save() before super().save() in NimbusBranchesForm so that branch feature values are persisted before the changelog snapshot is taken * Adds assertions to the existing test to verify the changelog captures the submitted feature values Fixes #14998
jaredlockhart
force-pushed
the
2026-03-20-history-feature-values
branch
from
db087fc to
57d195c
Compare
yashikakhurana
approved these changes
Mar 20, 2026
| def save(self, *args, **kwargs): | ||
| experiment = super().save(*args, **kwargs) | ||
| self.branches.save() | ||
| experiment = super().save(*args, **kwargs) |
Contributor
There was a problem hiding this comment.
that's even more cleaner
Collaborator
Author
There was a problem hiding this comment.
Only the cleanest 🙏 🧹
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
NimbusBranchesForm.save()calledsuper().save()which triggeredNimbusChangeLogFormMixin.save()to generate the changelog snapshot beforeself.branches.save()ran, causing the changelog to capture stale feature values instead of the updated onesThis commit
save()inNimbusBranchesFormto callModelForm.save()directly, then generates the changelog after all branch and feature value saves are completeFixes #14998